Use date tagged files for logging #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamltyson
approved these changes
Oct 24, 2025
Member
adamltyson
left a comment
adamltyson
left a comment
There was a problem hiding this comment.
LGTM. Tested locally and works well.
The tests are failing, but looks like the mouselight website is down?
Member
Author
|
Seems so, I think test failures are related to uptime rather than the current changes. I'll merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
Unlinking the log files on each
brainrenderimport was causing issues when multiple copies ofbrainrenderare run simultaneously. See #409.What does this PR do?
Tags the log for each run with a date to prevent conflicts. Adds a setting for maximum number of logs kept.
References
Closes #409
How has this PR been tested?
Tested locally, with
brainrenderandbrainglobe-heatmap.Is this a breaking change?
No
Does this PR require an update to the documentation?
No. I don't think we refer to the
brainrenderlogs by name anywhere in the docs.Checklist: