Corrected model-to-ceiling mapping under explained variance #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that Split-half/Spearman-Brown ceiling is a variance (reliability) ceiling, the following correction was made: Normalize neural scores as r^2 / reliability instead of (r/reliability) ^2.
Collaborator
|
Hi @sandervanbree ! Thanks for this PR and bringing the ceiling calculation issue to our attention. Your PR looks good but there are some larger decisions that we need to handle before we can merge this. Also, please ignore the one failure in the plugin unit test. Your PR looks good to me. |
Member
|
@KartikP we should also go through the neural benchmarks to see if they need to be individually corrected |
Member
|
I'm also attaching the email chain for reference. |
Author
|
OK thanks, feel free to ping me if I can be of further help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Split-half/Spearman-Brown ceiling is a variance (reliability) ceiling, the following correction was made: Normalize neural scores as r^2 / reliability instead of (r/reliability) ^2.