This repository was archived by the owner on Jan 5, 2024. It is now read-only.
add visual search #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
mschrimpf
reviewed
Jul 24, 2020
Comment on lines
25
to
30
|
|
||
| ml_brain_pool = MLBrainPool(base_model_pool, model_layers) | ||
|
|
||
| for identifier, model in ml_brain_pool.items(): | ||
| brain_translated_pool[identifier] = model | ||
|
|
||
| for identifier, model in cornet_brain_pool.items(): | ||
| brain_translated_pool[identifier] = model | ||
|
|
||
| def MLSearchPool(target_img_size=28, search_image_size=224): | ||
| target_model_pool = BaseModelPool(input_size=target_img_size) |
Comment on lines
+5
to
+7
| layers = { | ||
| 'vgg-16': [f'block{i + 1}_pool' for i in range(3,5)], | ||
| } |
Member
There was a problem hiding this comment.
I would create another vgg-16 BrainModel from the same underlying BaseModel that makes these exact commitments
Author
There was a problem hiding this comment.
The issue is that the "target_image" size is just 28x28 pixels. So we will need to exclusively define which layer will work for a specific ML model. So isn't it much better that we commit these layers in a separate py file? i.e. which layer to use for which ML model?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check score_model example on visual search benchmark.