Skip to content

Update issue templates #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kalaspuffar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update issue templates #7

kalaspuffar wants to merge 2 commits into from

Conversation

@kalaspuffar
Copy link
Member

@kalaspuffar kalaspuffar commented Jul 31, 2019

No description provided.

@kalaspuffar
Copy link
Member Author

kalaspuffar commented Jul 31, 2019

Hi @bertfrees, @PaulRambags, and @joeha480

What do you think about these templates for pull requests and issues?
Could this be added to all repositories?

Best regards
Daniel

joeha480
joeha480 reviewed Jul 31, 2019
View reviewed changes
Copy link
Contributor

@joeha480 joeha480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like everything is applicable to this/these projects. As it is it may confuse more than help.

@bertfrees
Copy link
Contributor

bertfrees commented Jul 31, 2019 •
edited
Loading

@joeha480 I think it's more a proposal to start with and to refine. I believe Daniel copied it from some other project.

PaulRambags
PaulRambags reviewed Aug 1, 2019
View reviewed changes
@bertfrees
Copy link
Contributor

bertfrees commented Aug 1, 2019

Does it make sense to have a PULL_REQUEST_TEMPLATE? Possibly with just a link to CONTRIBUTING.md?

@kalaspuffar
Copy link
Member Author

kalaspuffar commented Aug 1, 2019

Hi @bertfrees

It depends if we think a structured pull request description with specific sections will help with the reviewing process. I've been helped by it in the past so I'm positive, but I'm open to the discussion.

Best regards
Daniel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joeha480 joeha480 joeha480 left review comments

@PaulRambags PaulRambags PaulRambags approved these changes

@bertfrees bertfrees Awaiting requested review from bertfrees

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kalaspuffar @bertfrees @joeha480 @PaulRambags