Skip to content

chore: merge local workspace changes#47

Merged
braedonsaunders merged 2 commits intomainfrom
codex/merge-local-changes-20260226
Feb 26, 2026
Merged

chore: merge local workspace changes#47
braedonsaunders merged 2 commits intomainfrom
codex/merge-local-changes-20260226

Conversation

@braedonsaunders
Copy link
Owner

This PR contains all current local workspace changes, including orchestrator runtime improvements, verification path handling, and related tests.

@braedonsaunders braedonsaunders merged commit 6b5d5b0 into main Feb 26, 2026
1 check passed
@braedonsaunders braedonsaunders deleted the codex/merge-local-changes-20260226 branch February 26, 2026 05:39
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd35669a1f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +551 to +553
const rebased = rebaseAbsoluteVerificationPath(projectRootResolved, absolutePath)
if (rebased) return path.resolve(projectRootResolved, rebased)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve absolute paths already inside project root

This path-resolution order rebases every absolute verification path before checking whether it already points inside projectRoot, so valid root-level absolute paths (for example /repo/package.json or /repo/README.md) can be rewritten to non-existent nested paths like /repo/workspace/oneshot/package.json via suffix candidates and then fail file_exists/file_contains checks. The regression is triggered whenever a check uses an absolute in-repo path that does not match your anchor set (src, packages, etc.), causing deterministic verification to report false negatives.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant