Strengthen replan fallback and task tracking#43
Conversation
5dee4af to
254b05f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 254b05f070
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!modelDecision) { | ||
| emitSupervisorThought(run.id, { | ||
| reasoning: "Replan decision unavailable from provider — accepting current state.", | ||
| action: "accept", | ||
| }) | ||
| return {} |
There was a problem hiding this comment.
Run deterministic fallback when replan decision is missing
The new if (!modelDecision) branch exits with action: "accept" before invoking buildDeterministicFallbackDecision(), so any failure path where buildReplanDecision() throws (for example provider/model lookup errors before the structured fallback object is produced) now leaves failed/blocked tasks untouched. That bypasses the retry/skip recovery this commit added for other no-op decisions, and can leave runs stuck with unrecovered failures instead of progressing through deterministic fallback handling.
Useful? React with 👍 / 👎.
Summary
Testing