Skip to content

Codex/fix release asset collisions#41

Merged
braedonsaunders merged 6 commits intomainfrom
codex/fix-release-asset-collisions
Feb 24, 2026
Merged

Codex/fix release asset collisions#41
braedonsaunders merged 6 commits intomainfrom
codex/fix-release-asset-collisions

Conversation

@braedonsaunders
Copy link
Owner

No description provided.

@braedonsaunders braedonsaunders merged commit 9128a16 into main Feb 24, 2026
1 check passed
@braedonsaunders braedonsaunders deleted the codex/fix-release-asset-collisions branch February 24, 2026 06:01
@chatgpt-codex-connector
Copy link

💡 Codex Review

const openSucceeded = keptRunning || Boolean(detectedUrl)

P1 Badge Require live launch before marking Open as successful

The Open flow now treats a run as successful whenever detectedUrl is non-empty (keptRunning || Boolean(detectedUrl)), even if the newly started terminal process already exited. Because detectedUrl is seeded from preferredUrl, a stale URL from prior metadata can make a failed launch look healthy (session.status = "passed", appStatus = "running"), which can hide real startup failures from users and any automation consuming deploy session state.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant