Upgraded all dependencies; switched to Glide; modified types to int64…#132
Upgraded all dependencies; switched to Glide; modified types to int64…#132SamuelMarks wants to merge 4 commits intobradleyfalzon:masterfrom
Conversation
… for better compatibility with new dependencies
![gopherci[bot]](https://avatars.githubusercontent.com/in/889?s=60&v=4){kind=small}
| rootLogger := logger.New(os.Stdout, build, os.Getenv("LOGGER_ENV"), os.Getenv("LOGGER_SENTRY_DSN")) | ||
| logger := rootLogger.With("area", "main") | ||
| logger.With("build", build).Info("starting gopherci") | ||
| logger_ := rootLogger.With("area", "main") |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var logger_ should be logger
| } | ||
|
|
||
| db, err := db.NewSQLDB(sqlDB, os.Getenv("DB_DRIVER")) | ||
| db_, err := db.NewSQLDB(sqlDB, os.Getenv("DB_DRIVER")) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var db_ should be db
| var queuePush = make(chan interface{}) | ||
|
|
||
| gh, err := github.New(rootLogger, analyse, db, queuePush, int(integrationID), integrationKey, os.Getenv("GITHUB_WEBHOOK_SECRET"), os.Getenv("GCI_BASE_URL")) | ||
| gh_, err := github.New(rootLogger, analyse, db_, queuePush, integrationID, integrationKey, os.Getenv("GITHUB_WEBHOOK_SECRET"), os.Getenv("GCI_BASE_URL")) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var gh_ should be gh
|
|
||
| // Web routes | ||
| web, err := web.NewWeb(rootLogger.With("area", "web"), db, gh) | ||
| web_, err := web.NewWeb(rootLogger.With("area", "web"), db_, gh_) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var web_ should be web
| ) | ||
| queue := queue.NewMemoryQueue(logger.Testing()) | ||
| queue.Wait(context.Background(), &wg, c, func(job interface{}) {}) | ||
| queue_ := queue.NewMemoryQueue(logger.Testing()) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var queue_ should be queue
| } | ||
|
|
||
| func (g *GitHub) NewInstallation(installationID int) (*Installation, error) { | ||
| func (g *GitHub) NewInstallation(installationID int64) (*Installation, error) { |
There was a problem hiding this comment.
golint: exported method GitHub.NewInstallation should have comment or be unexported
| } | ||
| json, _ := json.Marshal(comments) | ||
| fmt.Fprint(w, string(json)) | ||
| json_, _ := json.Marshal(comments) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var json_ should be json
| json, _ := json.Marshal(comments) | ||
| fmt.Fprint(w, string(json)) | ||
| var comments []*github.PullRequestComment | ||
| json_, _ := json.Marshal(comments) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var json_ should be json
| func (q *GCPPubSubQueue) receive(ctx context.Context, f func(interface{})) { | ||
| err := q.subscription.Receive(ctx, func(ctx xContext.Context, msg *pubsub.Message) { | ||
| logger := q.logger.With("messageID", msg.ID) | ||
| logger_ := q.logger.With("messageID", msg.ID) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var logger_ should be logger
| } | ||
|
|
||
| logger := web.logger.With("analysisID", analysisID) | ||
| logger_ := web.logger.With("analysisID", analysisID) |
There was a problem hiding this comment.
golint: don't use underscores in Go names; var logger_ should be logger
1 participant
No description provided.