Skip to content

Replace uniq with slices.Compact #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashantv merged 1 commit into from
Jan 26, 2025
Merged

Replace uniq with slices.Compact #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions internal/tracetest/clean.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"path/filepath"
"regexp"
"runtime"
"sort"
"slices"
"strconv"
"strings"
)
Expand Down Expand Up @@ -81,8 +81,8 @@ func (r fileLineReplacer) Replacements() []string {
// Sort the lines in the file, and remove duplicates.
// The result will be a slice of unique line numbers.
// The index of each line in this slice + 1 will be its new line number.
sort.Ints(fileLines)
fileLines = uniq(fileLines)
slices.Sort(fileLines)
fileLines = slices.Compact(fileLines)

for idx, origLine := range fileLines {
replaceLine := idx + 1
Expand All @@ -93,20 +93,3 @@ func (r fileLineReplacer) Replacements() []string {
}
return allReplacements
}

// uniq removes contiguous duplicates from v.
// The slice storage is re-used so the original slice
// should not be used after calling this function.
func uniq[T comparable](items []T) []T {
if len(items) == 0 {
return items
}

newItems := items[:1]
for _, item := range items[1:] {
if item != newItems[len(newItems)-1] {
newItems = append(newItems, item)
}
}
return newItems
}
Loading