fix: Increase Sequence number only if it's not a flow.#18
Open
noels wants to merge 1 commit intobpmnServer:mainfrom
Open
fix: Increase Sequence number only if it's not a flow.#18noels wants to merge 1 commit intobpmnServer:mainfrom
noels wants to merge 1 commit intobpmnServer:mainfrom
Conversation
- So that sequential numbers display sensible consecutive numbers, only increase seq when the item type is not 'bpmn:SequenceFlow'
Collaborator
|
I agree. but it will not match, logging information |
Author
|
I didn't notice the logs. Where can I find that code? |
Author
|
I guess I could, as an alternative, decorate the flows so that the sequence is the same in the logs. |
Collaborator
|
That would be much better solution, also will show which flow was taken |
Author
|
I will take a look and try figure out why the decorations on the flows are not showing and come back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that sequential numbers display sensible consecutive numbers, only increase seq when the item type is not 'bpmn:SequenceFlow'
seq numbers displayed in the instance details page are non-consecutive because there is no label on 'bpmn:sequenceFlow' elements. This results in 1, 3, 5 being displayed on the labels for items that display the seq number.
This change makes the displayed sequence number consecutive:
