Skip to content

fix: serialize string info values as JSON#95

Merged
nikku merged 3 commits intomainfrom
issue-88-fix
Mar 16, 2026
Merged

fix: serialize string info values as JSON#95
nikku merged 3 commits intomainfrom
issue-88-fix

Conversation

@barinali
Copy link
Contributor

Proposed Changes

This pull request aims to fix the string serialization with JSON.stringify.

Checklist

Ensure you provide everything we need to review your contribution:

  • Contribution meets our definition of done
  • Pull request establishes context
    • Link to related issue(s), i.e. Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}
    • Brief textual description of the changes
    • Screenshots or short videos showing UI/UX changes
    • Steps to try out, i.e. using the @bpmn-io/sr tool

Copilot AI review requested due to automatic review settings March 12, 2026 21:20
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 12, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes how Zeebe variable info is derived from string atomicValue values by ensuring they are serialized as JSON string literals, preserving quotes and escaping control characters for UI/editor display.

Changes:

  • Serialize string atomicValue values via JSON.stringify when computing variable.info.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case to assert the fix we implement. Code wise it looks ok, given that strings are now returned raw (without ticks).

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Mar 16, 2026
@barinali
Copy link
Contributor Author

Please add a test case to assert the fix we implement. Code wise it looks ok, given that strings are now returned raw (without ticks).

@nikku, I have #94 as the test pull request. Are there any specific test cases in your mind I should be incorporating?

@nikku nikku changed the base branch from issue-88 to main March 16, 2026 21:53
@nikku nikku requested review from a team, barmac and jarekdanielak March 16, 2026 21:53
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 16, 2026
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage incorporated from #94 is great, thank you ⭐

@nikku nikku merged commit fadfb4e into main Mar 16, 2026
5 checks passed
@nikku nikku deleted the issue-88-fix branch March 16, 2026 21:57
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants