Conversation
- only copy static dir if existing - only copy existing source files - add barebones example - adjust preact meta to distinguish from barebones
moritztim
approved these changes
Jan 7, 2025
Contributor
moritztim
left a comment
moritztim
left a comment
There was a problem hiding this comment.
Looks good to me, aside from that one thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, until now Bext technically worked for minimal web extensions, but created a lot of excess build files and had some opinions about structure. So this PR (and also #9) address issues such as #8, to allow for more flexibility in application structure.
The changes introduces in this PR:
main.tscontentScriptexamplesexamples/barebonesexample to remove everything but a basic content_scriptexamples/preactmanifest/code/icons to better distinguish from barebonesexamples/preactcss, because wtf is that?