Open
Conversation
remove unneeded check for empty tree
Fix for missing shas in status, --verbose option to summary
I plan to use it to check validity of open submodules in the constuctor of `RepoAST`.
Factored `renderIndex` out of `writeRAST`
Will need to be able to use it on data before AST is created.
Changed the parser to use it for clone types.
Previously, you could not write out `RepoAST` objects containing paths such ast `x/y`. I exposed a helper function, `buildDirectoryTree` used to translate the flat set of stored changes into a hieararchical tree, so that I could test it.
…chies Add support for writing hierarchical trees.
Added AST, shorthand, and read/write support for specifying open submodules and changes inside them. This work required some refactoring to allow for invoking the logic to write ASTs for the special situation of submodules.
Support for open submodules.
`createRepo` and `createMultiRepos` that take care of: 1. making temp path 2. accepting either AST or shorthand input
…anipulators Addded test utilities for non-manipulators.
Was using `shorthand.length` as end character instead of `end`, breaking override parsing with open submodules. Added test to catch this condition.
Fixed bug parsing overrides.
- also added missing assertions to methods in submodule_util - discovered a bug in `getSubmoduleChanges` to be addressed in a later fix
Wrote tests for `submodule_util.js`.
Previously, it did not detect the removal of a submodule.
Fixed `gitSubmoduleChanges` to report deletions.
git meta close checks for unpushed or uncommited changes
- jshint - close breathing test
Istanbul Code Coverage Tool
We were passing in `Commit` objects, causing it to crash. Changed it to pass in the commit (string) shas instead and it works. I suspect the id is used in a newer version.
- factored `RepoStatus` into its own module and test - require several other factorizations and changes to make testable.
in `testMultiRepoManipulator`.
Relative URLs to support '.'.
I needed to use a string that was too large to pass on the command line.
Add option to read from file in `write-repos`.
It was not possible to use them at all.
Wasn't necessary but was annoying. Also, eliminating call to `getRepoStatus` will make it faster.
Fixed bug with `write-repos` shorthand args.
Remove `ensureCleanAndConsistent` from `push`.
use correct method to set remote url
Work rate limits
I made a poor decision early on to let a null head imply a bare repo in the test framework. Now, I need to change some parts of the code to handle headless repositories, and I'd like to be able to reflect such a state in the test framework. This change decouples the two concepts of bareness and headlessness.
So it can work with bare repositories.
Otherwise, it will leave the meta-repo in an unrecognizable state, thinking the submodule is open when it actually isn't.
Do not allow normal failures in opening one submodule cause us to abort opening other submodules.
Improve resilience with "half-baked" submodules, and of open overall
A bare but non-empty repository with no current branch was unreadable. Addressed by wrapping call to `getCurrentBranch` in a try/catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.