refactor: remove unnecessary clone() calls across codebase#400
Merged
Conversation
- Replace into_* methods with as_* reference-returning methods on config types (ColorSchemeConfig, LangCodeConfig, SortKeyConfig), eliminating clone() in both the methods and their call sites in build/serve commands - Change &PathBuf parameters to idiomatic &Path across usecase, MCP tool, and service layers (15 functions) - Add Tags::iter() method to avoid clone().into_iter() in parallel tag rendering - Use as_ref().map() instead of clone().map() in Template::title() - Reorder operations in markdown convert to eliminate ScrapKey clone https://claude.ai/code/session_01FdQ9m12gdn8vJ3gKagC9eC
Performance Test Results 🚀Build Time: 0.985 seconds Executed with: scraps build -v |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
types (ColorSchemeConfig, LangCodeConfig, SortKeyConfig), eliminating
clone() in both the methods and their call sites in build/serve commands
and service layers (15 functions)
rendering
https://claude.ai/code/session_01FdQ9m12gdn8vJ3gKagC9eC