refactor: construct BacklinksMap once and pass by reference#397
Merged
Conversation
…nders BacklinksMap was being constructed independently in each render (IndexRender, ScrapRender, TagRender, TagsIndexRender), causing redundant O(N) work per render. Now constructed once in BuildUsecase::execute() and passed as &BacklinksMap, also removing the scraps field from ScrapRender and TagRender structs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Performance Test Results 🚀Build Time: 0.987 seconds Executed with: scraps build -v |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BacklinksMaponce inBuildUsecase::execute()and pass&BacklinksMapto all renders (IndexRender, ScrapRender, TagRender, TagsIndexRender)BacklinksMap::new()calls from each render'srun()methodscraps: Vec<Scrap>field fromScrapRenderandTagRenderstructs, simplifying their constructorsTest plan
mise run cargo:qualitypasses (build, test, fmt, clippy)mise run perf:testpasses (build time: 2.373s < 4s threshold)🤖 Generated with Claude Code