Refactor performance test into mise task#396
Merged
Conversation
Allow running performance tests locally via `mise run perf:test`. Mirrors the CI performance workflow: builds in release mode, clones boykush/wiki, and measures scraps build time against the 4-second threshold. https://claude.ai/code/session_01CoxJUJYFYayKoUEBhtU5Cf
Replace inline build/test steps in performance.yml with `mise run perf:test`. The mise task outputs duration and status to GITHUB_OUTPUT when running in CI, keeping PR comment functionality intact. https://claude.ai/code/session_01CoxJUJYFYayKoUEBhtU5Cf
Performance Test Results 🚀Build Time: 2.777 seconds Executed with: scraps build -v |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted the performance testing logic from the GitHub Actions workflow into a reusable mise task (
.mise-tasks/perf/test). This improves maintainability by centralizing the test logic and allows it to be run locally as well as in CI.The workflow now simply invokes
mise run perf:testinstead of containing all the build timing and threshold checking logic inline. The task handles:Related Issues
Additional Notes
This refactoring makes the performance test easier to run locally for development and testing purposes, while maintaining the same CI behavior. The mise task outputs
durationandstatusvariables that the workflow consumes for PR comments.https://claude.ai/code/session_01CoxJUJYFYayKoUEBhtU5Cf