Add bindings for no onednn includes builds#8
Merged
boydjohnson merged 1 commit intomainfrom Jul 12, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new bindings feature to toggle between build-time generated bindings and pre-generated vendored bindings, and updates module imports and build logic accordingly.
- Introduces the
bindingsfeature and guards binding inclusion inlib.rs - Wraps bindgen code generation in
build.rsunder thebindingsfeature check - Updates
Cargo.tomlwith the new feature, version bump, and docs configuration
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Conditional include! and pub use of binding modules based on bindings, OpenCL, SYCL |
| src/bindings/sycl_bindings.rs | Auto-generated SYCL interop bindings via rust-bindgen |
| src/bindings/ocl_bindings.rs | Auto-generated OpenCL interop bindings via rust-bindgen |
| src/bindings.rs | Declares binding modules (bindings, ocl_bindings, sycl_bindings) |
| build.rs | Skips bindgen generation when bindings feature is enabled |
| Cargo.toml | Adds bindings feature, adjusts version, links metadata, and enables docs for all-features |
Comments suppressed due to low confidence (2)
src/lib.rs:5
- New conditional compilation branches for the
bindingsfeature (and combined GPU/runtime flags) should be covered by CI tests to verify correct module inclusion and exclusion.
#[cfg(not(feature = "bindings"))]
Cargo.toml:3
- [nitpick] The version was downgraded from "0.1.0" to "0.0.1". Please confirm this change aligns with your release strategy and intended versioning.
version = "0.0.1"
d02693b to
7898bc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.