Skip to content

Add bindings for no onednn includes builds#8

Merged
boydjohnson merged 1 commit intomainfrom
feature/doc-features
Jul 12, 2025
Merged

Add bindings for no onednn includes builds#8
boydjohnson merged 1 commit intomainfrom
feature/doc-features

Conversation

@boydjohnson
Copy link
Copy Markdown
Owner

No description provided.

@boydjohnson boydjohnson requested a review from Copilot July 12, 2025 15:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new bindings feature to toggle between build-time generated bindings and pre-generated vendored bindings, and updates module imports and build logic accordingly.

  • Introduces the bindings feature and guards binding inclusion in lib.rs
  • Wraps bindgen code generation in build.rs under the bindings feature check
  • Updates Cargo.toml with the new feature, version bump, and docs configuration

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lib.rs Conditional include! and pub use of binding modules based on bindings, OpenCL, SYCL
src/bindings/sycl_bindings.rs Auto-generated SYCL interop bindings via rust-bindgen
src/bindings/ocl_bindings.rs Auto-generated OpenCL interop bindings via rust-bindgen
src/bindings.rs Declares binding modules (bindings, ocl_bindings, sycl_bindings)
build.rs Skips bindgen generation when bindings feature is enabled
Cargo.toml Adds bindings feature, adjusts version, links metadata, and enables docs for all-features
Comments suppressed due to low confidence (2)

src/lib.rs:5

  • New conditional compilation branches for the bindings feature (and combined GPU/runtime flags) should be covered by CI tests to verify correct module inclusion and exclusion.
#[cfg(not(feature = "bindings"))]

Cargo.toml:3

  • [nitpick] The version was downgraded from "0.1.0" to "0.0.1". Please confirm this change aligns with your release strategy and intended versioning.
version = "0.0.1"

@boydjohnson boydjohnson force-pushed the feature/doc-features branch from d02693b to 7898bc8 Compare July 12, 2025 15:16
@boydjohnson boydjohnson merged commit aff88b2 into main Jul 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants