Fix some things I noticed while reading infsup.lisp #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w array Perhaps this was true once, but currently, this function does not return a new chas-array (untested but afaict it returns nil), and none of the 3 callers use its return value. `chas-array-assure-room` ends up calling `grow-storage-vector` which can extend the underlying storage-vector in place; so the chas-array identity doesn't change.
…ctions I don't see this holding in present code. For example `insert-row-before-row` does not call `insert-row-at-row-no`. Nor would this make sense algorithmically — rows are doubly-linked, so holding a row pointer you have immediate access to the adjacent rows whose pointers you need to adjust. Whereas methods that take row numbers must walk the list to reach the area to adjust. Moreover, to compute the `row-row-no` index, you'd also need to walk it! The opposite layering _could_ be reasonably efficient. But in current code, it's not done either, e.g. `insert-row-at-row-no` does all necessary set-*-row by itself. - `append-row` does count `(length-in-rows self)` then calls `insert-row-at-row-no`, which will traverse the list again. But it's not strictly taking "existing box row", just a box.
UNTESTED! But order of args was clearly wrong. I don't see `insert-cha-before-cha` nor `insert-cha-after-cha` used anywhere.
Member
|
Thanks @cben! I think this looks correct, will take a closer look at it shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
caveat: Presently I'm just reading the code, not running it, so all untested.
insert-cha-before-chawas clearly wrong.I don't see
insert-cha-before-chanorinsert-cha-after-chaused anywhere.