This PR adds support for passing oob options to the cmtool.bat script #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…templates in order to allow passing of configuration management options to the provisioning scripts.
…hat hand off the cm_options to the cm's installer. However, the semantics of these can change depending on the cmtool, since not all support or need options.
arizvisa
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the older PRs that was submitted (#182) added a user variable
CM_OPTIONSthat allowed one to pass options to the salt-bootstrap script. A recent PR adds aCHEF_LICENSEoption in order to pass options into the script/cmtool.bat script in order to allow the user to constrain the licensing for chef.It is likely in the future that there might be more configurable options that could be exposed in order to customize the user's chosen cmtool. So in order to support passing an oob option to the configuration of a cmtool, this PR aims to consolidate all of those needs into a single user variable,
CM_OPTIONS. This should hopefully reduce the template complexity of adding an explicit user variable for every possible cmtool installation feature in the future.It is intended that the semantics of this option is specific to the cmtool as not all cmtools need arbitrarily flexible parameters.