Expand Custom Music options in Dungeons #148
Open
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowser0000
reviewed
Sep 14, 2023
Comment on lines
+228
to
+234
|
|
||
| // If we're awaiting the lightning, we should stop the music. | ||
| // This could be a false positive due to stormy mobs, but it wouldn't make much of a difference. | ||
| if (awaitingLightning && event.name.equals("ambient.weather.thunder")) { | ||
| awaitingLightning = false; | ||
| if (bloodroom != null) bloodroom.stop(); | ||
| } |
Owner
There was a problem hiding this comment.
You should use PacketReadEvent instead of PlaySoundEvent as it doesn't fire if the player has sounds disabled. See how it's implemented here https://github.com/bowser0000/SkyblockMod/blob/development/src/main/java/me/Danker/features/loot/LootTracker.java#L47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to Custom Music in dungeons:
phaseone.wavto allow overriding the Maxor bossfight music. Normally the F7P1 music is different from the typical dungeon bossfight music, and this change reflects that.