Skip to content

packages: update ecr-credential-provider version for 1.32-1.35#876

Open
mselim00 wants to merge 4 commits intobottlerocket-os:developfrom
mselim00:ecr-cred
Open

packages: update ecr-credential-provider version for 1.32-1.35#876
mselim00 wants to merge 4 commits intobottlerocket-os:developfrom
mselim00:ecr-cred

Conversation

@mselim00
Copy link
Copy Markdown

@mselim00 mselim00 commented Mar 18, 2026

Issue number:

N/A

Description of changes:

Updates the version of the ecr-credential-provider to latest for versions 1.32 to 1.35.

This includes dropping a patch for aws-eusc since the change was included upstream:

On top of cleaning up the patches, this also lets us pick up a change to support public dualstack endpoints:

This addresses a gap first raised in awslabs/amazon-eks-ami#2592

Testing done:

  1. Locally built the kit with the updated credential providers
  2. Built aws-k8s-1.3{2,3,4,5} variants with the custom kits
  3. Ran instances with the custom AMIs and joined them to an EKS cluster
  4. Deployed a DaemonSet referencing a private image in my ECR repoistory
  5. Confirmed image pull succeeded for all 4 nodes

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@vigh-m
Copy link
Copy Markdown
Contributor

vigh-m commented Mar 27, 2026

Could you add a Signed-off-by: tag to your commits.
It should be easy enough to do with something like git rebase --exec.

@piyush-jena piyush-jena self-requested a review March 27, 2026 17:55
Signed-off-by: Mazen Selim <mazensel@amazon.com>
Signed-off-by: Mazen Selim <mazensel@amazon.com>
Signed-off-by: Mazen Selim <mazensel@amazon.com>
Signed-off-by: Mazen Selim <mazensel@amazon.com>
@mselim00
Copy link
Copy Markdown
Author

added those signatures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants