Skip to content

Conversation

@hanc2006
Copy link
Contributor

No description provided.

@mpociot mpociot merged commit 5ced159 into botman:master Sep 28, 2018
@holtkamp
Copy link
Contributor

Nice contribution @hanc2006 !

@mpociot are you considering a new minor release for this?

@holtkamp
Copy link
Contributor

holtkamp commented Oct 1, 2018

mmm, when looking closer it seems some files are missing?

  • BotMan\Drivers\Telegram\TelegramContactDriver
  • BotMan\BotMan\Messages\Attachments\Contact

So I suppose this is work-in-progress 😄

@hanc2006
Copy link
Contributor Author

hanc2006 commented Oct 1, 2018

Hi @holtkamp,
BotMan\BotMan\Messages\Attachments\Contact is not in this repository. Is a part of botman/botman project. You can use the contact attachment inside a conversation like:

...

$this->askForContact('Please send us your phone number.', function (Contact $contact) {
     $this->say('Thank you. Your contact has been linked.');
},
null,
Keyboard::create()
   ->type(Keyboard::TYPE_KEYBOARD)
   ->oneTimeKeyboard()
   ->resizeKeyboard()
   ->addRow(KeyboardButton::create('Phone number')->requestContact())
   ->toArray()
);

...

@holtkamp
Copy link
Contributor

holtkamp commented Oct 1, 2018

@hanc2006 thanks for the swift heads-up!

Aah, yeah, found it here: https://github.com/botman/botman/blob/cfa07d5734fdaf2b6cc4c8eb501b747d93c1f2b3/src/Messages/Attachments/Contact.php

But what about BotMan\Drivers\Telegram\TelegramContactDriver?

When looking at the master branch of this repo https://github.com/botman/driver-telegram, no such class is currently part of it...

https://github.com/botman/driver-telegram/tree/5ced1597ed9c7eae842ca9c09ef61478821172db/src

hence my doubt...

@hanc2006
Copy link
Contributor Author

hanc2006 commented Oct 1, 2018

Yes right. It’s for manual loading the driver. I will pull the new file with changes 👍

@holtkamp
Copy link
Contributor

holtkamp commented Oct 16, 2018

@hanc2006 I noticed you updated the feature branch: https://github.com/hanc2006/driver-telegram/tree/contact-driver

with the TelegramContactDriver

Looking forward to work with this! So would a new Pull Request be applicable?

@holtkamp
Copy link
Contributor

holtkamp commented May 23, 2019

@hanc2006 and @mpociot bump on this?

the TelegramContactDriver

is still missing from https://github.com/botman/driver-telegram/tree/master/src

It seems this PR never got merged in the fork and this repo

hanc2006#1

ranrinc pushed a commit to krdesigns-com/driver-telegram that referenced this pull request Nov 21, 2019
@feralheart feralheart mentioned this pull request May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants