Move checkSymmetry to serializer, introduce checkFromBinary#724
Merged
AndrejMitrovic merged 2 commits intobosagora:v0.x.xfrom Apr 5, 2020
Merged
Move checkSymmetry to serializer, introduce checkFromBinary#724AndrejMitrovic merged 2 commits intobosagora:v0.x.xfrom
checkSymmetry to serializer, introduce checkFromBinary#724AndrejMitrovic merged 2 commits intobosagora:v0.x.xfrom
Conversation
Because it really does belong here. Originally it was put in Types because Serializer and Deserializer were split, so there was no 'common' module, but now that they are one, it makes sense to have it there.
As explained in the documentation, a common issue is non-compiling `fromBinary`.
Codecov Report
@@ Coverage Diff @@
## v0.x.x #724 +/- ##
==========================================
+ Coverage 91.14% 91.33% +0.19%
==========================================
Files 63 62 -1
Lines 4809 4892 +83
==========================================
+ Hits 4383 4468 +85
+ Misses 426 424 -2
Continue to review full report at Codecov.
|
AndrejMitrovic
approved these changes
Apr 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit and their description. Related to #687