Fix quorum pre-image unit test#3182
Open
hewison-chris wants to merge 8 commits intobosagora:v0.x.xfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.x.x #3182 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 165 165
Lines 17131 17131
=======================================
Hits 15192 15192
Misses 1939 1939
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hewison-chris
force-pushed
the
fix_quorum_preimage_test
branch
from
edc2eeb to
4fa452f
Compare
Contributor
Author
|
This test is never failing locally so is really hard to fix at the moment. |
Contributor
If this fails again on CI even with this change, How about solving this problem with other approaches later. |
Contributor
|
But if you think there are any improvements in the test result, it's not bad to merge it. |
hewison-chris
force-pushed
the
fix_quorum_preimage_test
branch
8 times, most recently
from
f13fa34 to
c05fa03
Compare
hewison-chris
force-pushed
the
fix_quorum_preimage_test
branch
8 times, most recently
from
905f495 to
80e9ac5
Compare
hewison-chris
force-pushed
the
fix_quorum_preimage_test
branch
7 times, most recently
from
47cdc41 to
5db20f9
Compare
hewison-chris
force-pushed
the
fix_quorum_preimage_test
branch
3 times, most recently
from
4116762 to
fdc6b0a
Compare
hewison-chris
force-pushed
the
fix_quorum_preimage_test
branch
from
fdc6b0a to
f797d13
Compare
The max listeners should be the sum of the validators, fullnodes and registry. In `base.d` it is correctly calculated so just remove the `testConf` hardcoded setting.
The test relies on the fact that all Genesis and outsider validators are enrolled in the last block of the cycle. Let's just assert this is the case. Maybe we will need to refactor the test if this assert fails.
These steps should not be required as the next step has retries.
For blocks 21 -> 39 it is better to send the tx to one client and check for the height in the test code as there are outsider validators. In the `generateBlocks` function it checks that the txs are gossiped to all the validators before setting the time for the next block. But as the outsiders were not enrolled until block 20 the client may gossip the tx before it has updated the peers it sends to. Normally this does not matter because once an envelope is recieved by the newly enrolled node it will try to fetch it.
If we use auto enroll then we do not need to manually enroll the outsiders for their second enrollment.
hewison-chris
force-pushed
the
fix_quorum_preimage_test
branch
from
f797d13 to
ba7f961
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has often failed recently. See commits for details on fix.