Skip to content

Update srcset-info.js #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SquadraCorse wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update srcset-info.js #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/srcset-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
* Add an image candidate, unless it's a dupe of something that exists already.
*/
SrcsetInfo.prototype._addCandidate = function(imageInfo) {
for (var j = 0; j < this.imageCandidates.length; j++) {
for (var j = 0, len = this.imageCandidates.length; j < len; j++) {
var existingCandidate = this.imageCandidates[j];
if (existingCandidate.x == imageInfo.x &&
existingCandidate.w == imageInfo.w &&
Expand All @@ -119,7 +119,7 @@
for (var i = 0; i < descriptors.length; i++) {
var desc = descriptors[i];
if (desc.length > 0) {
var lastChar = desc[desc.length-1];
var lastChar = desc.slice(-1); // so crappy browsers understand it as well
var value = desc.substring(0, desc.length-1);
var intVal = parseInt(value, 10);
var floatVal = parseFloat(value);
Expand Down