Skip to content

chore: remove unused variable #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bootun merged 1 commit into from
Apr 6, 2025
Merged

chore: remove unused variable #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cmd/impact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,13 @@ var impactCmd = &cobra.Command{
}

var (
outputFormat string // 输出格式(json, text)
oldCommit string
newCommit string
repo string // 仓库路径
scope string // 报告的变更范围(all, service)
)

const (
OutputFormatJson = "json"
OutputFormatText = "text"

ScopeAll = "all"
ScopeService = "service"
)
Expand All @@ -50,7 +46,6 @@ func init() {
impactCmd.Flags().StringVarP(&newCommit, "new", "n", "", "new commit")
impactCmd.Flags().StringVarP(&repo, "repo", "r", ".", "repo path")
impactCmd.Flags().StringVarP(&scope, "scope", "s", ScopeAll, "report scope, options: all, service")
impactCmd.Flags().StringVarP(&outputFormat, "format", "f", OutputFormatJson, "output format, options: json, text")
}

func Impact(oldCommit, newCommit string) {
Expand Down
3 changes: 2 additions & 1 deletion veronica_example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
version: 1.0.0-alpha
version: '1.0.0'

services:
# every item is a service
refresh_playlet_info:
Expand Down