Skip to content

Provide info on currently running jobs#31

Merged
andrus merged 4 commits intobootique:masterfrom
atomashpolskiy:#21_2
Feb 21, 2017
Merged

Provide info on currently running jobs#31
andrus merged 4 commits intobootique:masterfrom
atomashpolskiy:#21_2

Conversation

@atomashpolskiy
Copy link
Member

@andrus , please take a look

@atomashpolskiy
Copy link
Member Author

I also left a little bit of refactoring done per #24

@atomashpolskiy
Copy link
Member Author

wait, I think I have to change something

@atomashpolskiy
Copy link
Member Author

What I've done is move callback related stuff from SimpleRunnableJobFactory into SingleJob and JobGroup, because that's the place where the "final" map of parameters is collected (merged from what came from the calling code and what has been specified in YAML/CLI).

@atomashpolskiy
Copy link
Member Author

Hi @andrus , just wanted to remind you about this PR, thanks!

@andrus andrus merged commit 6866b82 into bootique:master Feb 21, 2017
andrus added a commit that referenced this pull request Feb 21, 2017
@andrus andrus added this to the 0.14 milestone Feb 21, 2017
andrus added a commit that referenced this pull request Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants