tmt: Fix var-mount test to use booted container image #1927
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the test-install-to-filesystem-var-mount.sh script to align with best practices for TMT tests and bootc image testing. The changes correctly switch from pulling a remote image to using the locally booted container image via bootc image copy-to-storage. It also streamlines the test by removing unnecessary host modifications like SELinux enforcement, usr-overlay, and dnf install commands. Furthermore, the root logical volume is now configured to use 100%FREE space, enhancing test robustness. The addition of a bind mount for /usr/lib/bootc/bound-images.d effectively disables logically bound images, matching the described intent. Overall, these changes improve the test's accuracy, efficiency, and maintainability.
Use copy-to-storage to add the booted container to podman storage instead of pulling a remote image. This matches the pattern used by other TMT tests and ensures we test the actual bootc under test. Changes: - Use localhost/bootc from copy-to-storage instead of remote image - Disable LBIs via bind mount of /usr/share/empty - Remove unnecessary host modifications (usr-overlay, dnf install, etc.) - Use 100%FREE for root LV to ensure sufficient space for deployment Assisted-by: OpenCode (Opus 4.5) Signed-off-by: ckyrouac <ckyrouac@redhat.com>
ckyrouac
force-pushed
the
var-mount-test
branch
from
3d005d2 to
859dfbe
Compare
| fi | ||
| rm -vrf /usr/lib/bootupd/updates | ||
| rm -vrf /usr/lib/bootc/bound-images.d | ||
| # Build a derived image that removes LBIs |
There was a problem hiding this comment.
Sorry I meant to ask before also - why are we doing this? How do LBIs relate to this issue?
Is it about saving disk space?
There was a problem hiding this comment.
just a small optimization to avoid pulling the LBIs into the TMT test VM's container storage for the bootc install.
There was a problem hiding this comment.
OK. But let's try to ensure that we include rationale for things like this in comments and commit messages.
|
I cherry picked this into #1926 because we need both to fix CI right now. |
2 participants
Use copy-to-storage to add the booted container to podman storage instead of pulling a remote image. This matches the pattern used by other TMT tests and ensures we test the actual bootc under test.
Changes:
Assisted-by: OpenCode (Opus 4.5)