Add custom boost::locale::numpunct#170
Draft
Flamefire wants to merge 5 commits intoboostorg:developfrom
Draft
Conversation
No longer required as supported char types can be asserted now. Also avoids confusion which one a user should use.
Flamefire
force-pushed
the
numpunct_fix
branch
from
d6330b7 to
34fef7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #65 onto develop with current changes incorporated. Hence closes #65
Contains the original commit(s) from @salvoilmiosi of #65 squashed and rebased onto develop to fix the conflicts.
On top some refactoring and documentation additions to suit current state of the library.
Will also contain tests.
Design:
boost::locale::numpunctfor all backendsdecimal_point_str&thousands_sep_strto provide possibly encoded variants of the decimal and thousand separatorsdecimal_point&thousands_sepreturn best-effort single-chars, by default falling back to the "C" localefacet.thousands_sep()&facet.decimal_point()and doing "regular" streaming usingstd::locale) get the expected results.