fixed valid? method to return boolean type #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| describe '#valid?' do | ||
| it { should be_valid } | ||
| it { expect([true, false]).to include(subject.valid?) } |
There was a problem hiding this comment.
What do you think about splitting this in two tests: asserting that valid? returns true when the Bic is valid and false otherwise?
Author
There was a problem hiding this comment.
Ok, but I think the shorter form does the same job, as it "expects that the return value of that function is either true or false". Any other value will not pass.
Is it about readability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for
valid?method to return boolean type