fix. errors of register login by FBagdeli · Pull Request #47 · boolean-uk/team-dev-client-c12

FBagdeli · 2024-07-18T15:03:07Z

No description provided.

aws-amplify-eu-west-2 · 2024-07-18T15:04:29Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47.d1ytr8ocn5wsgw.amplifyapp.com

LeonardoSaraceli · 2024-07-18T15:16:35Z

src/context/auth.js

+
+	if(password.length < 1) return 'Password is required'
+	if(password.length < minLength ) return 'Password should be at least 8 characters long'
+	if(password.length > 24) return 'Password should be less than 24 characters'


Probably wait for the database changes, if this is required surely could be used, but for right now, i guess this is not supposed to be added.

MyrtheDullaart · 2024-07-18T15:13:34Z

src/context/auth.js

+	const handleRegister = async (email, password, setErrors) => {
+		try {
+			const validatedEmail = validationEmail(email)
+			if(validatedEmail !== true) {


if(!validatedEmail)

MyrtheDullaart · 2024-07-18T15:22:22Z

src/context/auth.js

+	if(!hasUppercase) return 'Password should have at least one uppercase letter'
+	if(!hasNumber) return 'Password should have at least one number'
+	if(!hasSpecialCharacter) return 'Password should have at least one special character'
+	return 'ValidPassword'


I would return true or false for this function and just display 1 error message

LeonardoSaraceli · 2024-07-18T15:23:16Z

src/context/auth.js

+				throw new Error(validatedEmail)
+			}
+			const validatedPassword = validationPassword(password)
+			if(validatedPassword !== 'ValidPassword') {


!validatedPassword

LeonardoSaraceli · 2024-07-18T15:25:37Z

src/context/auth.js

+	if(!hasUppercase) return 'Password should have at least one uppercase letter'
+	if(!hasNumber) return 'Password should have at least one number'
+	if(!hasSpecialCharacter) return 'Password should have at least one special character'
+	return 'ValidPassword'


return true

Auenc · 2024-07-19T13:02:34Z

src/context/auth.js

-
+	const handleLogin = async (email, password, setErrors) => {
+
+		const passwordRequirments = 'Password must be at least 8 characters long and include at least one uppercase letter, one number, and one special character.'


Let's put these errors in a utils/errors.js file so they're not scattered around the app

Auenc · 2024-07-19T13:02:51Z

src/context/auth.js

+		const emailErrorMessage = "Please enter a valid email"
+
+		try {
+			const validatedEmail = validationEmail(email)


the formatting here looks wrong

Auenc · 2024-07-19T13:03:12Z

src/context/auth.js

-        navigate("/verification")
-    }
+	const handleRegister = async (email, password, setErrors) => {
+		const passwordRequirments = 'Password must be at least 8 characters long and include at least one uppercase letter, one number, and one special character.'


let's put these in utils/errors.js

Auenc · 2024-07-19T13:03:21Z

src/context/auth.js

+		const emailErrorMessage = "Please enter a valid email"
+
+		try {
+			const validatedEmail = validationEmail(email)


formatting doesn't look correct

Auenc · 2024-07-19T13:03:28Z

src/context/auth.js

-        localStorage.setItem('token', token)
-        navigate('/')
-    }
+			// localStorage.setItem('token', token)


let's remove commented code

Auenc · 2024-07-19T13:04:13Z

src/pages/login/index.js

 	const onChange = (e) => {
 		const { name, value } = e.target;
 		setFormData({ ...formData, [name]: value });
+		setErrors('')


let's use null as a default value

Auenc · 2024-07-19T13:04:22Z

src/pages/login/index.js

@@ -38,10 +40,11 @@ const Login = () => {
 							label={"Password *"}


check the formatting here - it doesn't look right

Auenc · 2024-07-19T13:04:31Z

src/pages/register/index.js

 	const { onRegister } = useAuth();
 	const [formData, setFormData] = useState({ email: "", password: "" });
-
+	const [errors, setErrors] = useState('')


let's use null as a default value

Auenc · 2024-07-19T13:04:37Z

src/pages/register/index.js

 	const onChange = (e) => {
 		const { name, value } = e.target;
 		setFormData({ ...formData, [name]: value });
+		setErrors('')


let's use null as a default value

Auenc · 2024-07-19T13:05:07Z

src/service/apiClient.js

+        if(res.status === 'fail') {
+            throw new Error(res.data.error)
+        }
+        return await login(email, password)


no need for this await

Farshad added 5 commits July 17, 2024 12:47

errorRegisterPageHandler Created

8515a83

feat : showError

5270cae

feat: email-password-client-side-validation

f1d0a08

feat: errors-for-handleRegister Done

fa68ba3

feat: login-errors-handler Done

9896ebf

FBagdeli requested review from LeonardoSaraceli and MyrtheDullaart July 18, 2024 15:03

LeonardoSaraceli reviewed Jul 18, 2024

View reviewed changes

MyrtheDullaart requested changes Jul 18, 2024

View reviewed changes

LeonardoSaraceli reviewed Jul 18, 2024

View reviewed changes

LeonardoSaraceli requested changes Jul 18, 2024

View reviewed changes

Farshad added 2 commits July 19, 2024 09:39

fix: validated-email-password-changed

957b8a6

style: some of the files

ae889a0

FBagdeli requested review from LeonardoSaraceli and MyrtheDullaart July 19, 2024 10:32

LeonardoSaraceli previously approved these changes Jul 19, 2024

View reviewed changes

FBagdeli requested a review from Hamada-AB July 19, 2024 12:10

MyrtheDullaart previously approved these changes Jul 19, 2024

View reviewed changes

FBagdeli removed the request for review from Hamada-AB July 19, 2024 12:16

Auenc suggested changes Jul 19, 2024

View reviewed changes

refactor

43bf1f9

FBagdeli dismissed stale reviews from MyrtheDullaart and LeonardoSaraceli via 43bf1f9 July 19, 2024 14:17

FBagdeli requested review from Auenc, LeonardoSaraceli and MyrtheDullaart July 19, 2024 14:19

refactor-No2

0f0262c


		const handleLogin = async (email, password, setErrors) => {

		const passwordRequirments = 'Password must be at least 8 characters long and include at least one uppercase letter, one number, and one special character.'

		@@ -38,10 +40,11 @@ const Login = () => {
		label={"Password *"}

Conversation

FBagdeli commented Jul 18, 2024

Uh oh!

aws-amplify-eu-west-2 bot commented Jul 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants