Skip to content

Jones/handle error #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jay-Topher wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jones/handle error #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14da079
added fourth arg to make the middleware an error handler
Jay-Topher Sep 19, 2021
898eadd
Taking out render method
Jay-Topher Sep 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,22 @@ app.use(function (
});

// error handler
app.use(function (err: any, req: express.Request, res: express.Response) {
// When a middleware has four args, express sees it as an error handler
app.use(function (
err: any,
req: express.Request,
res: express.Response,
_next: express.NextFunction,
) {
// set locals, only providing error in development
res.locals.message = err.message;
res.locals.error = req.app.get('env') === 'development' ? err : {};

// render the error page
res.status(err.status || 500);
res.render('error');
return;
// There's no active view engine so the render method would throw an error in the console
// res.render('error');
});

export default app;