Feature/problems api full dashboard #8
Conversation
| deploymentByRemoteId: () => mocks.Deployment(), | ||
| taskByRemoteId: () => mocks.Task(), | ||
| allProjects: () => new MockList(9), | ||
| allProjects: () => new MockList(600), |
There was a problem hiding this comment.
Is it convention in the mocks to just drop in a magic number? (I'm not sure how strict they are?)
This feels like something that might be best in a named const?
There was a problem hiding this comment.
As there quite a few other mocks that use random values here I thought it makes sense to do that same. Maybe it would be best to have a few different values here to mock displays of different sizes though.
services/api/src/typeDefs.js
Outdated
| deleted: String | ||
| } | ||
|
|
||
| type ProblemIdentifier { |
There was a problem hiding this comment.
I'm a little confused by this - I think it might be the name - but is this supposed to uniquely identify a problem across multiple projects? That is, provide summary information?
If so, I think this needs to be reworked just a little - let's chat when you have a sec.
There was a problem hiding this comment.
Yep I think we need to chat about this - essentially this was created because returning all problems (e.g. [Problem]) isn't enough to see which projects/environments have been affected. So rather than adjust the Problem type to include project related fields - this ProblemIdentifier type was created. Since then, it might make sense to add a project field in to the Problem type. But lets chat!
services/keycloak/start.sh
Outdated
| echo Creating resource problem | ||
|
|
||
| echo '{"name":"problem","displayName":"problem","scopes":[{"name":"view"},{"name":"add"},{"name":"delete"}],"attributes":{},"uris":[],"ownerManagedAccess":""}' | /opt/jboss/keycloak/bin/kcadm.sh create clients/$CLIENT_ID/authz/resource-server/resource --config $CONFIG_PATH -r ${KEYCLOAK_REALM:-master} -f - | ||
| echo '{"name":"problem","displayName":"problem","scopes":[{"name":"viewAll"},{"name":"view"},{"name":"add"},{"name":"delete"}],"attributes":{},"uris":[],"ownerManagedAccess":""}' | /opt/jboss/keycloak/bin/kcadm.sh create clients/$CLIENT_ID/authz/resource-server/resource --config $CONFIG_PATH -r ${KEYCLOAK_REALM:-master} -f - |
There was a problem hiding this comment.
This is going to need to move into its own function - by the time your code runs, the problems system will have already have run, and therefore this probably won't run again
There was a problem hiding this comment.
Ah yes - although this is something I wanted to chat about. Is this global check even needed? There are checks on to view each problem and project/environment already.
| "react-modal": "^3.8.1", | ||
| "react-nice-dates": "^1.0.2", | ||
| "react-select": "^2.1.1", | ||
| "react-select": "^3.0.0", |
There was a problem hiding this comment.
Does this change the effective installed version at all?
I don't think we have to worry - I just want to know if there are ramifications to pushing up the major version?
There was a problem hiding this comment.
the existing selects work nicely still - this allows us to use some of the latest async stuff as well now
| @@ -0,0 +1,105 @@ | |||
| import React, { useState, Fragment } from "react"; | |||
There was a problem hiding this comment.
So - I want to make sure of this, are these new components you're adding to the root namespace generic enough to be in the root namespace? The last accordion I moved as a sub-element of the problems space because there were specific assumptions made about its use.
There was a problem hiding this comment.
After another think about this - I've pull out the component specific stuff for this core accordion and moved all the logic that modifies the columns into the parent components. The only think left is some css that needs to be set for define column widths, but I don't think that is a problem?
Fix indentation for annotations in rabbitmq template
Upgraded Trivy to v0.9.0
Label namespaces with lagoon.sh/environmentType
Update curl to `7.70.0-r0` in the PHP images
…toring Add a new environment variable to control New Relic browser monitoring.
Improve resilience of logs-forwarder
…rn/apollo-server-express-2.14.2 Bump apollo-server-express from 2.9.4 to 2.14.2
…updates Billing UI Updates
Moving contributing and CoC to docs root.
Updated default robot token duration to 500 days.
Auto-idler cronjobs
…er-script Bash script to check and update TLS broken routes
docs: Kubernetes installation
Adding varnish control port to k8s helmfiles
First iteration of Lagoon Version Update Helper
…task Add missing `builddeploy-kubernetes:complete` task to RC notifications
Update project logic for Harbor projects
Remove accidentally committed values file
Logging updates
We parse the nginx log message into the relevant fields, but some users may want the original log message.
Set notification channels as an array
It's possible the denial is due to a network error or some other temporary issue
…lysite-groups-of-10 Additional tests and formatting for POLYSITES greater than 10
…ached-deny HOTFIX: Don't cache keycloak authz denials in redis
Keep raw nginx log message
Add helper script for labelling namespaces
…cluster Add Cluster Name on Billing Group Admin pages
…ipt-enhancements Some enhancements for check_acme_routes.sh script
Add PECL Yaml 2.1.0 to the base PHP images
13 participants
No description provided.