Add RETR_SOCKETS #524
Draft
Add RETR_SOCKETS #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a global that contains all of the sockets currently serving RETR. The application can use it to analyze performance on a per-socket basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's a global that contains all of the sockets currently serving RETR. The application can use it to analyze performance on a per-socket basis.
Problem
I have a need in my application to track some performance statistics on a per-connection basis. The easiest way to do that is to maintain a global data structure that contains all of the file descriptors of interest. Unfortunately, that requires modifying libunftp, not just my application. This change is somewhat intrusive, and might be of limited utility to other consumers. That's why I have left the PR in "Draft" status for now. Can you suggest any better way for me to get this information? My only idea is to use the same interface that sockstat(1) uses. However, that won't allow me to discriminate between sockets serving RETR commands (the ones I care about), and other sockets.