Open
Conversation
Open
Owner
rebaseすれば？ |
bokusunny
reviewed
Jul 13, 2019
sy-tencho
force-pushed
the
docker-ci
branch
2 times, most recently
from
7722cb8 to
6263bab
Compare
Fix: fix typo & try again Fix: fix notation Fix: remove image build from work flow Fix: remove job work flowでjobが正しく呼ばれているかテスト executorを変えてテスト workflowの設定を変えてテスト Fix: fix workflow notation Fix: fix workflow version Fix: notation Add: add orbs Fix: ネストを修正 Fix: ネストを修正 remove unnecessay diff
bokusunny
requested changes
Jul 14, 2019
bokusunny
reviewed
Jul 14, 2019
Co-Authored-By: Taishi Murakami <liverpool1407@g.ecc.u-tokyo.ac.jp>
Co-Authored-By: Taishi Murakami <liverpool1407@g.ecc.u-tokyo.ac.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
resolve #353
before #357
詳細
masterブランチの変更があるとCI上でdocker image buildしてdocker hub に自動でpushされます。
その他
謎にオールをした勢いで書いたので、ミスの原因が発見できず無駄なコミットを増やしてしまいました。申し訳ありません。けど我ながら結構良いPRだなと思うので許してください。