Open
Conversation
Mostly to pull protobufjs 7.2.4 to get a fix for a vulnerability.
diogotorres97
approved these changes
Sep 4, 2023
- upgrade ava to v6.2.0 - drop deprecated API usage; refactor callback test cases - tests that use callback-based gRPC methods return promises to signal when test assertions are done ... - also ensure that the callback-based variants are still covered - drop calls to test.cb() and t.end() - do async-await consumption of duplex streams - spawn async task to consume reads on client stream - await that task after writes to that stream are set up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly to pull protobufjs 7.2.4 to get a fix for a vulnerability.