Fix accuracy of grid_frequency

[lowar]

• documentation says 0.1Hz but its actually 0.01Hz

[bohdan-s]

Hi. This one actually changes if using http or modbus methods. Really annoying. Not sure how to resolve that cleanly.

[lowar]

Ah, didn't know that. The last update to the WiNet-S module made the websocket connection unusable, so I can't test it at the moment.

Maybe one could replace the per register accuracy with a dict of the connection type? So instead of

  accuracy: 0.1

you would write

  accuracy:
    http: 0.1
    modbus: 0.01
    sungrow: 0.1

This simple change to the SubgrowClient will accomplish that. This way the client will work with the simple and the extended notation:

diff --git a/SungrowClient/SungrowClient.py b/SungrowClient/SungrowClient.py
index 867ebdb..41e5b33 100644
--- a/SungrowClient/SungrowClient.py
+++ b/SungrowClient/SungrowClient.py
@@ -279,7 +279,10 @@ class SungrowClient():
                             register_value = default
 
                     if register.get('accuracy'):
-                        register_value = round(register_value * register.get('accuracy'), 2)
+                        accuracy_value = register.get('accuracy')
+                        if isinstance(accuracy_value, dict):
+                          accuracy_value = accuracy_value.get(self.inverter_config['connection'])
+                        register_value = round(register_value * accuracy_value, 2)
 
                     # Set the final register value with adjustments above included 
                     self.latest_scrape[register_name] = register_value

Should I open a PR?

[michbeck100]

I would say the simple format should be default for all registers where accuracy is the same for all channels. So we should support both formats.

[michbeck100]

Just had a better look at your proposal. LGTM. Please create a PR

[lowar]

Done. bohdan-s/SungrowClient#12