-
Notifications
You must be signed in to change notification settings - Fork 4
Updated 'spool2klipper.cfg' to contain the correct macro name for when spool is cleared. #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
psyfiend
wants to merge
21
commits into
bofh69:main
Choose a base branch
from
psyfiend:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated _CLEAR_ macro to reflect name in spool2klipper.cfg Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
When storing new spool_data the _CLEAR_ macro will be called first. Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Updated MSG and descriptions Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Clarified some information Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Clarified descriptions of how the services works when changing spools. Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Update to reflect example file and install instructions. Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Signed-off-by: psyfiend <30286151+psyfiend@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier I updated the example macros and readme.md to refer to the macro name
_SPOOLMAN_CLEAR_FIELDSbut apparently I forgot to also update thespool2klipper.cfgfile to reflect this updated macro name.Change made to `spool2klipper.cfg:
Changed this line:
klipper_spool_clear_macro = "_SPOOLMAN_CLEAR_SPOOL"To this:
klipper_spool_clear_macro = "_SPOOLMAN_CLEAR_FIELDS"