Conversation
bodowd
force-pushed
the
fix-gha
branch
9 times, most recently
from
803b51f to
758e293
Compare
The existing github actions workflow is based off duckdb extension ci tools toolchain, but it doesn't seem to work for duckdb_rdkit. This commit attempts to simplify the github actions workflow and not follow the extension ci toolchain. A future direction could be to look into getting this to build with the extension ci toolchain and make duckdb_rdkit available as a community extension
`make test` in the past probably built the release and ran the tests. This commit now builds the extension and runs the tests in separate steps
The extension has been updated to use DuckDB v1.4.4 and it needs DuckDB v1.4.4 in order to build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing github actions workflow is based off duckdb extension ci tools toolchain, but duckdb_rdkit is built differently due to the RDKit dependency. We currently modify the extension ci tools toolchain to build duckdb_rdkit, for example to install and use conda for RDKit.
This commit attempts to simplify the github actions workflow
A future direction could be to look into getting this to build with the extension ci toolchain and make duckdb_rdkit available as a community extension