Fix logging issues #472
Merged
Fix logging issues #472
+248
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juankx-bodo
force-pushed
the
jkx/Fix_log_level_with_file_handlers
branch
from
2df5197 to
cd5172f
Compare
hadia206
reviewed
Jan 20, 2026
Contributor
hadia206
left a comment
hadia206
left a comment
There was a problem hiding this comment.
The code looks correct to me.
I'm not familiar with logging so will let Kian or John give approval.
juankx-bodo
force-pushed
the
jkx/Fix_log_level_with_file_handlers
branch
from
1c7fb29 to
18e3acd
Compare
Contributor
john-sanchez31
left a comment
john-sanchez31
left a comment
There was a problem hiding this comment.
Looks good. Just one comment below. I'll let the final approval to Kian
knassre-bodo
approved these changes
Jan 28, 2026
Contributor
knassre-bodo
left a comment
knassre-bodo
left a comment
There was a problem hiding this comment.
One comment, otherwise LGTM
Comment on lines
+2246
to
+2247
| reset_logger("pydough") | ||
| reset_logger("pydough.mask_server") |
Contributor
There was a problem hiding this comment.
If these are the values to be used, then replace __name__ when get_logger is used with these strings in all the places it is currently used (execute_relational.py and mask_server.py)
juankx-bodo
force-pushed
the
jkx/Fix_log_level_with_file_handlers
branch
from
d004fb6 to
27e7d70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.