Skip to content

Conversation

@scott-routledge2
Copy link
Contributor

@scott-routledge2 scott-routledge2 commented Apr 29, 2025

Changes included in this PR

See here for more context. Essentially the environment variables for the buffer pool are split between cluster-level, node-level and rank-level granularity, which can cause confusion.

For example:
BODO_BUFFER_POOL_MEMORY_SIZE_MiB specifies the memory available to this rank for the buffer pool, whereas
BODO_BUFFER_POOL_STORAGE_CONFIG_1_SPACE_PER_DRIVE_GiB Is the space available for each node (assuming one drive).

Ideally IMO BODO_BUFFER_POOL_MEMORY_SIZE_MiB should just specify the amount of space available to all processes (on the same node) and then that space gets divided among ranks evenly, but then it creates a weird situation with BODO_BUFFER_POOL_MALLOC_FREE_TRIM_THRESHOLD_MiB still being per rank.

Adding "worker" makes it a bit more clear but then the environment variables too long e.g. BODO_BUFFER_POOL_WORKER_MALLOC_FREE_TRIM_THRESHOLD_MiB

Testing strategy

User facing changes

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

@scott-routledge2 scott-routledge2 changed the title [WIP] Refactor env vars to clarify they are for individual ranks Refactor env vars to clarify they are for individual ranks Apr 30, 2025
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.42%. Comparing base (e4dcdf8) to head (9f6c537).
Report is 20 commits behind head on main.

❌ Your project check has failed because the head coverage (66.42%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   66.52%   66.42%   -0.11%     
==========================================
  Files         176      176              
  Lines       63332    63491     +159     
  Branches     8875     8891      +16     
==========================================
+ Hits        42133    42172      +39     
- Misses      18574    18691     +117     
- Partials     2625     2628       +3     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants