Skip to content

Remove bundled BusyBox binaries #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobrofon merged 1 commit into from
Nov 9, 2025
Merged

Remove bundled BusyBox binaries #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ dependencies {
// implementation "com.github.topjohnwu.libsu:service:${libsuVersion}"
// Optional: For com.topjohnwu.superuser.io classes
// implementation "com.github.topjohnwu.libsu:io:${libsuVersion}"
// Optional: Bundle prebuilt BusyBox binaries
implementation "com.github.topjohnwu.libsu:busybox:${libsuVersion}"
}

def signingPropsFile = file("signing.properties")
Expand Down
4 changes: 1 addition & 3 deletions app/src/main/java/ru/nsu/bobrofon/easysshfs/ShellBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: MIT
package ru.nsu.bobrofon.easysshfs

import android.util.Log
import com.topjohnwu.superuser.BusyBoxInstaller
import com.topjohnwu.superuser.Shell
import com.topjohnwu.superuser.Shell.Builder
import ru.nsu.bobrofon.easysshfs.log.AppLog
Expand All @@ -26,7 +26,6 @@ object ShellBuilder {

private fun build(): Shell {
val builder = Builder.create()
.setInitializers(BusyBoxInstaller::class::java.get())

return if (isMagiskV27x()) {
// TODO: remove logging after the following release (or maybe a few releases)
Expand All @@ -45,7 +44,6 @@ object ShellBuilder {

private fun isMagiskV27x(): Boolean {
val sh = Builder.create()
.setInitializers(BusyBoxInstaller::class::java.get())
.setFlags(Shell.FLAG_NON_ROOT_SHELL)
.build()

Expand Down
Loading