This repository was archived by the owner on Apr 5, 2018. It is now read-only.
Emailable export#44
Open
JoshStaff wants to merge 1 commit intoboboldehampsink:masterfrom
JoshStaff:master
Open
Emailable export#44JoshStaff wants to merge 1 commit intoboboldehampsink:masterfrom JoshStaff:master
JoshStaff wants to merge 1 commit intoboboldehampsink:masterfrom
JoshStaff:master
Conversation
… the result later or download the responsr
Owner
|
This is on the map, yes. Can you tidy it up first? It's a mess (merge conflicts, checked-in csv's, no PSR-2, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Able to select options on whether or not you want to export and email it later or download the response – This solved the issue with the export crashing prior to it presenting the result. Is this PR something you would consider beneficial? If so, I am happy to tidy it up (There are code changes / refactors I'd like to do), add tests & work with you on this.