fix: Normalize tag names before creating tags on-demand #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where if the tag `"tag"` existed and you tried to tag a new recipe `"Tag"`, it would fail to find the existing tag and attempt to create a new tag named `"tag"` (the normalized form of `"Tag"`)
boblail
force-pushed
the
lail/make-tags-case-insensitive
branch
from
88480e3 to
d2798f7
Compare
boblail
force-pushed
the
lail/make-tags-case-insensitive
branch
from
feb0808 to
c7eee5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where if the tag
"tag"existed and you tried to tag a new recipe"Tag", it would fail to find the existing tag and attempt to create a new tag named"tag"(the normalized form of"Tag")Resolves https://boblail.sentry.io/issues/4740469244/