Confirm on pass if insufficient resources#71
Merged
coyotte508 merged 7 commits intoboardgamers:masterfrom Aug 9, 2025
Merged
Conversation
Players can no longer accidentally skip buying resources while lacking enough to power all plants. When attempting to pass during the Resources phase without sufficient resources, the UI now prompts for confirmation. This helps prevent accidental misplays and makes the consequence of passing explicit. The sufficiency check accounts for hybrid plants that can use either coal or oil, ensuring the prompt reflects real options.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a confirmation prompt when players attempt to pass during the Resources phase without having sufficient resources to power all their plants. The change aims to prevent accidental misplays by making players explicitly confirm they want to skip resource purchasing when they lack adequate fuel.
- Adds resource sufficiency checking logic that accounts for hybrid plants
- Integrates confirmation prompt into existing pass validation flow
- Imports Player type for the new functionality
Member
|
sorry for the additional commits, and thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of change
Players can no longer accidentally skip buying resources while lacking enough to power all plants. When attempting to pass during the Resources phase without sufficient resources, the UI now prompts for confirmation.
This helps prevent accidental misplays and makes the consequence of passing explicit. The sufficiency check accounts for hybrid plants that can use either coal or oil, ensuring the prompt reflects real options.
Testing
Verified manually by running through scenarios in the provided viewer.