Skip to content

From JRo's implementation#2

Open
Grissess wants to merge 32 commits intoboamaod:masterfrom
GumballCrash:master
Open

From JRo's implementation#2
Grissess wants to merge 32 commits intoboamaod:masterfrom
GumballCrash:master

Conversation

@Grissess
Copy link

Things added:

  • Module: "spikebot" for limited interoperability with SpikeBot (currently only karma)
  • Module: "inject" for injection/introspection using FIFOs on OSs that support them (currently *nixes, AFAIK)
  • Library: "ircbot"; see below.

Things changed:

  • Better handling of Unicode: the ircbot library was incorporated under license and changed slightly to handle Unicode at the network level, where it is most stable. Other modules were slightly changed to accommodate.
  • New hook functions in modules: "init" for startup, "finish" for shutdown.

GumballCrash and others added 28 commits September 30, 2013 00:10
…fig file. A generic config file is provided.
Skype display name is now shown in IRC instead of Skype handle.
Added information to the Readme; made the bot show display names of Skype users when available
…%\#channel) would crash the bot. Now it just doesn't mirror them.
Added auto-reply module. *Untested, probably broken.*
@boamaod
Copy link
Owner

boamaod commented Jul 24, 2014

Thanks a lot, I appreciate the pull request, however I want to keep my branch as simple and as minimal as I can.

By that I mean that the main goal of my Skype to IRC bot is to broadcast Skype chat messages to IRC and vice versa, so different technologies or even ideologies incorporated in software (free/open software and protocols versus the rest) don't hinder the communication. However, all the extras provided by expandability of IRC can never made to be fully available through Skype, so I find there is no point in trying to force it. It's the problem of inferior software development model that Skype is using and I am not really in a position to solve this problem and I think I should not put my efforts into that.

However, I am willing to accept pull requests to implement Skype chat better or make the bot more universal and follow standards, good practises etc, but pull requests should be proposed in smaller functional chunks, so I can review the code. I also want to keep my branch modular, that is I don't want to hardcode and start maintaining modules, that can be used from their respective sources.

If you have hints of that kind of improvements made in commits embraced in your pull request, I can check these out myself, however making new pull requests would be more effective.

The ^C/\x03 control character was already stripped, but not the foreground and background colors after it.
Multiple places use the decode_irc method to get their msg text. This is a sign of another problem, in that there shouldn't be separate code for sending messages for modules and the "default", but this is a simple fix to strip color codes from all text from IRC.
Only remove up to 2 digits for each.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants