Skip to content

[cpp] add explicit hdf5 v1.12.0 dependency #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
immanuelazn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[cpp] add explicit hdf5 v1.12.0 dependency #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions r/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,9 @@ Suggests:
RcppAnnoy
Depends:
R (>= 4.0.0)
SystemRequirements: C++17,
HDF5 (>= 1.12) [detected using base libraries, pkg-config 'hdf5' or 'h5cc' fallbacks or via conda in order;
else set HDF5_CFLAGS/HDF5_LIBS],
Highway (>= 1.0.5) [optional; detected via pkg-config 'libhwy'/'hwy';
falls back to vendored build if not found]
Config/Needs/website: pkgdown, devtools, uwot, irlba, RcppHNSW, igraph, BiocManager, bioc::BSgenome.Hsapiens.UCSC.hg38, github::GreenleafLab/motifmatchr, github::GreenleafLab/chromVARmotifs, png, magrittr
2 changes: 1 addition & 1 deletion r/configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ if [ -z $HDF5_OK ]; then
fi

if [ -z $HDF5_OK ]; then
printf "\n\nUnable to locate libhdf5. Please install manually or edit compiler flags.\n"
printf "\n\nUnable to locate libhdf5 (>= 1.12.0). Please install manually or edit compiler flags.\n"
exit 1
fi

Expand Down
2 changes: 1 addition & 1 deletion r/configure.win
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if [ -z $HDF5_OK ]; then
fi

if [ -z $HDF5_OK ]; then
printf "\n\nUnable to locate libhdf5. Please install manually or edit compiler flags.\n"
printf "\n\nUnable to locate libhdf5 (>= 1.12.0). Please install manually or edit compiler flags.\n"
exit 1
fi

Expand Down
4 changes: 4 additions & 0 deletions r/tools/h5write.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@

#include "hdf5.h"

#if H5_VERS_MAJOR < 1 || (H5_VERS_MAJOR == 1 && H5_VERS_MINOR < 12)
#error "HDF5 version 1.12.0 or greater required"
#endif

#define H5FILE_NAME "SDS.h5"
#define DATASETNAME "IntArray"
#define NX 5 /* dataset dimensions */
Expand Down
Loading