Add Hookable support to Repository and wrap delegated model calls with hooks#2
Open
Add Hookable support to Repository and wrap delegated model calls with hooks#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
OperationandFlowviaGaskit::Core::Hookableso global/inline hooks can observe repository behavior.before,around, andafterhooks to support cross-cutting concerns like metrics and auditing.Description
Gaskit::Core::HookableintoGaskit::Repositoryand require the hookable helper withrequire_relative "core/hookable".delegate_common_model_methodswithhook_runner.apply_hooks(:before, :around, :after)so hooks execute around themodel.public_sendcall.hook_runnerhelper that allocates a repository instance for running hooks and expose instance helpersloggerandmodelfor use inside hooks.it "runs hooks around delegated calls"tospec/gaskit/repository_spec.rbthat verifiesaroundhooks run surrounding delegated calls.Testing
spec/gaskit/repository_spec.rbcovering around hooks on delegated methods.bundle exec rspec spec/gaskit/repository_spec.rbbut the environment reportedbundler: command not found: rspec, so automated test execution could not be completed.Codex Task