Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
with_contextusage or per-callcontext:.Description
rls_scope(&block)class method to store a repository-level scope block andbase_relation(context:)to return eithermodelor the executed scope usinginstance_exec.delegate_common_model_methodsto callbase_relation(context:)and accept acontext:keyword for delegated methods so queries go through the RLS layer.with_context(context)and aContextProxyclass that forwards common AR methods while injecting the provided context into delegated calls.README.mdwith an example usingrls_scopeandwith_context, and add specs inspec/gaskit/repository_spec.rbcovering default model behavior, applied RLS scopes, and context passing.Testing
spec/gaskit/repository_spec.rbwith tests for default behavior, applying the RLS scope, and passing context into the scope block.bundle exec rspec spec/gaskit/repository_spec.rbbut the run failed because the environment lacks the Bundler/rspec executables.bundle installshould be able to run the updated specs to confirm behavior.Codex Task