Skip to content

CATTRI-1: Fixed expose: :read preventing internal writes#9

Merged
bnlucas merged 2 commits intomainfrom
CATTRI-1
Dec 15, 2025
Merged

CATTRI-1: Fixed expose: :read preventing internal writes#9
bnlucas merged 2 commits intomainfrom
CATTRI-1

Conversation

@bnlucas
Copy link
Owner

@bnlucas bnlucas commented Dec 15, 2025

  • Added regression for expose: :read internal assignment (spec/cattri_spec.rb).
  • Adjusted writer logic to generate internal writers for read-only exposure (lib/cattri/attribute.rb) and updated allowed method expectations (spec/cattri/attribute_spec.rb).
  • Added coverage for skipped writer branch by stubbing writable? to false in the compiler spec (spec/cattri/attribute_compiler_spec.rb).
  • Ensured read-only writers remain private but callable internally and updated predicate/allowed methods grids accordingly.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (122638f) to head (8800af4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          378       378           
  Branches        59        59           
=========================================
  Hits           378       378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bnlucas bnlucas merged commit 32ee1bf into main Dec 15, 2025
8 checks passed
@bnlucas bnlucas deleted the CATTRI-1 branch December 15, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant